Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken on images taken by device's camera in portrait #9

Open
rousset opened this issue Dec 19, 2012 · 3 comments
Open

Broken on images taken by device's camera in portrait #9

rousset opened this issue Dec 19, 2012 · 3 comments

Comments

@rousset
Copy link

rousset commented Dec 19, 2012

I tried using this category on a project that has camera functionality. Unfortunately the scaled output is screwy when the input image is a photo taken in portrait mode. It comes out distorted. The type and magnitude of the distortion varies depending on what scaling mode you use, but it's always pretty severe.

Try using the image file below (direct from my iphone 4s) in the sample project. The distortion appears there for me.

https://dl.dropbox.com/u/24362489/image.jpg
@mattgemmell
Copy link
Owner

Interesting. You've got the code; feel free to submit a fix as a pull-request.

@dmorrow
Copy link

dmorrow commented Jan 11, 2013

I am seeing the same issue. All of the frame and size values are correct in the debugger, but then it's stretched vertically.

dmorrow added a commit to dmorrow/MGImageUtilities that referenced this issue Jan 14, 2013
@dmorrow
Fix for issue mattgemmell#9 - Broken on images taken by device's came…
b7b14ca 
…ra in portrait

mattgemmell#9

Takes into account that rotated images don't have their CGImage rotated, so the rect needs to be rotated to crop correctly.
@dmorrow dmorrow mentioned this issue Jan 14, 2013
Open
@huguesbr
Copy link

I've the same issue, any body wanting to merge this pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dmorrow @mattgemmell @huguesbr @rousset