Refs jazzband#1668: Fixed the unsortable session keys fallback

matthiask · Aug 21, 2024 · c8e22a6 · c8e22a6
1 parent 6fc5ce8
commit c8e22a6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/debug_toolbar/panels/request.py b/debug_toolbar/panels/request.py
@@ -64,5 +64,8 @@ def generate_stats(self, request, response):
                     (k, request.session.get(k)) for k in sorted(request.session.keys())
                 ]
             except TypeError:
-                session_list = [(k, request.session.get(k)) for k in request.session]
+                session_list = [
+                    (k, request.session.get(k))
+                    for k in request.session.keys()  # noqa: SIM118 (it's not a dict)
+                ]
             self.record_stats({"session": {"list": session_list}})
diff --git a/docs/changes.rst b/docs/changes.rst
@@ -13,6 +13,8 @@ Pending
 * Add translations for Bulgarian and Korean.
 * Update translations for several languages.
 * Include new translatable strings for translation.
+* Fixed a crash which happened in the fallback case when session keys cannot be
+  sorted.
 
 4.4.6 (2024-07-10)
 ------------------