Simplify creation of exception messages

maxmind · Dec 9, 2022 · eeb22f5 · eeb22f5
1 parent c1930c8
commit eeb22f5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/main/java/com/maxmind/db/Decoder.java b/src/main/java/com/maxmind/db/Decoder.java
@@ -448,7 +448,7 @@ private <T> Object decodeMapIntoObject(int size, Class<T> cls)
                     + " Java Type: " +parameterTypes[index].getCanonicalName());
                 }              
             }
-            throw new DeserializationException("Error creating object of type: " + cls.getSimpleName() + " - " + sbErrors.toString(), e);
+            throw new DeserializationException("Error creating object of type: " + cls.getSimpleName() + " - " + sbErrors, e);
         }
     }
 

diff --git a/src/main/java/com/maxmind/db/Reader.java b/src/main/java/com/maxmind/db/Reader.java
@@ -184,8 +184,7 @@ record = this.readNode(buffer, record, bit);
             try {
                 dataRecord = this.resolveDataPointer(buffer, record, cls);
             } catch (DeserializationException exception) {
-                String msgCause = Optional.ofNullable(exception).map(Exception::getMessage).orElse("");
-                throw new DeserializationException("Error getting record for IP " + ipAddress.toString() + " -  " + msgCause, exception);
+                throw new DeserializationException("Error getting record for IP " + ipAddress + " -  " + exception.getMessage(), exception);
             }
         }
         return new DatabaseRecord<>(dataRecord, ipAddress, pl);