platform artifact without mps-extensions #2204
Conversation
|
Looks good but the breaking change is unfortunate. Since most projects are currently using 2020.3, can we copy the relevant parts in 2020.3 so that it remains compatible, and apply the breaking change to 2021.1 only? |
I tried that first but got a bunch of "module visible from x and y" errors. I didn't investigate further why. I can take another look at this later. For me there is no urgent pressure right now to port this back to 2020.3. My initial problem with mps-extensions is fixed for now. Might be better to just to it in 2021.1 then and projects get change when they do the migration. |
|
Let's do it in 2021.1 only then. |
coolya
force-pushed
the
feature/platform-slim
branch
from
fae33de
to
9e4715a
Compare
|
Sorry for the huge delay I only got around working on this now. I rebased the changes onto master and changed the target branch. |
coolya
force-pushed
the
feature/platform-slim
branch
from
9e4715a
to
c9c0e2f
Compare
Added a new artifact to the mbeddr platform that doesn't repackage mps-extensions. It exposes the dependency to mps-extensions via the pom. This allows consumers of the artefact to decided which mps-extensions version they would like to use. This change breaks existing build scripts because of the new MPS build solution that does only build the mbeddr platform. To fix this open the build script in MPS and press F5 to fix all the references. The artefact that repackaged mps-extensions is still present and remains untouched. Down stream projects do not need to change their gradle scripts.
coolya
force-pushed
the
feature/platform-slim
branch
from
c9c0e2f
to
1d120e1
Compare
|
@sergej-koscejev do we still want this PR to be merged? |
Yes. I think we may want to revisit the names later (I would make the "slim" artifact the default and have a qualifier for the "fat" one: -bundled, -all, or something like that) but I think we can merge it to move forward. |
build: add separate platform artifact
Added a new artifact to the mbeddr platform that doesn't repackage
mps-extensions. It exposes the dependency to mps-extensions via the pom.
This allows consumers of the artefact to decided which mps-extensions
version they would like to use.
This change breaks existing build scripts because of the new MPS build
solution that does only build the mbeddr platform. To fix this open the
build script in MPS and press F5 to fix all the references.
The artefact that repackaged mps-extensions is still present and remains
untouched. Down stream projects do not need to change their gradle scripts.