Dirty checking not working for context tags

[saurabhnanda]

Can someone please confirm this bug:

class User < ActiveRecord::Base
  acts_as_taggable
  acts_as_taggable_on :admin_tags
end

u = User.last
u.tag_list_changed?
 => false 
u.admin_tag_list_changed?
NoMethodError: undefined method `admin_tag_list_changed?

[shekibobo]

👍 Confirmed, causing issue when using tag list fields in nested forms.

[shekibobo]

class User < ActiveRecord::Base
  acts_as_taggable_on :admin_tags
end

> u = User.last
> u.admin_tag_list << "NewTag"
> u.changed?
=> false
> u.admin_tag_list_changed?
 => false 
> u.changed_attributes
=> {}

So it looks like the fundamental assumption of dirty.rb is flawed:

def #{tag_type}_list_changed?
  changed_attributes.include?("#{tag_type}_list")
end

Using Rails 3.2.13 on Ruby 1.9.3-p392

[tilsammans]

Thanks for the failing specs. Is a fix underway or should I take a look?

[shekibobo]

I'm taking a look, but I don't know the library to well. If you've got a lead, let me know and I'll try it out.

[tilsammans]

I'm not available right now, but might be in a few hours.

I've marked this one to be included in 2.5.0, since I am even having trouble releasing 2.4.0 at this time. So try to be patient, there is a backlog with issues.

[tilsammans]

2.4.0 will be out on Tuesday and I think 2.5.0 (which will include your fix) should come fairly close behind.

Thanks for the contribution!

[tilsammans]

Just to be clear, your fix will be in 2.4.1 already.