Count on tagged_with / group_by query

[ghost]

This query works perfectly

Criterion.tagged_with(["java"], on: :skills).count

But adding a group_by clause breaks everything :

Criterion.tagged_with(["java"], on: :skills).group(:minimum_salary).count

ActiveRecord::StatementInvalid: PG::Error: ERROR:  syntax error at or near "AS"
SELECT COUNT(*) AS count_all,  AS , minimum_salary AS minimum_salary FROM "criterions" JOIN ...

[rgould]

I'm experiencing this as well.

[rgould]

Found a fix and issued a pull request:

#417

[ghost]

Thx for the workaround @rgould ! I was still experimenting this problem.

[bf4]

Trying to get master tests reliably passing, then will start merging again soon :)

[ghost]

OK I'll test it against your merge as soon as you'll release it !

[bf4]

@beg if you want to take a look, I've been unable to duplicate the sqlite3 failure I see on travis #430

[ghost]

My table definition

    create_table "criterions", force: true do |t|
      t.integer  "user_id"
      t.integer  "minimum_salary"
    ...
    end

The class itself :

class Criterion < ActiveRecord::Base
   acts_as_ordered_taggable_on :skills
...

The request that fails without the monkey patch of @rgould

Criterion.tagged_with(["java"], on: :skills).group(:minimum_salary).count

SELECT COUNT(*) AS count_all,  AS , minimum_salary AS minimum_salary FROM "criterions" JOIN taggings criterions_taggings_68443c0  ON criterions_taggings_68443c0.taggable_id = "criterions".id AND criterions_taggings_68443c0.taggable_type = 'Criterion' AND criterions_taggings_68443c0.tag_id = 3312 AND criterions_taggings_68443c0.context = 'skills' GROUP BY minimum_salary

You can see that there's a 'AS' in the middle of nowhere.
The monkey patch prevails from this.

 group = [] # Rails interprets this as a no-op in the group() call below

[bf4]

Can you rebase against master and force push?