Let '.count' work when tagged_with is accompanied by a group clause #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase against master and force push? |
|
@bf4 Just saw this now. I have rebase and forced-push the branch again. |
|
Thanks, will review. Can you update your spec to the expect syntax? |
|
@bf4 done! |
|
Just got bit by this one. Would love to see the fix merged into master. Thanks. |
|
@rgould Can you add your change to changelog.md and force push ? I will merge it once you do that. |
|
@seuros Done! Thanks! |
|
@rgould could you rebase ? the Actual change-log is different than yours. Thanks |
|
@seuros Derp, sorry about that. I've rebased and force-pushed. |
seuros
added a commit
that referenced
this pull request
Jan 27, 2014
Fix: Let '.count' work when tagged_with is accompanied by a group clause
rgarner
added a commit
to alphagov/transition
that referenced
this pull request
May 2, 2014
* This fixes the issue where the Mapping.with_traffic_summary scope would not chain with Mapping.tagged_with, generating invalid SQL when a `count` was required (falling over on `any?` and the like) * While we initially patched AATO ourselves, it turns out a fix was already merged for AATO 3.1.0 (mbleigh/acts-as-taggable-on#417) * 3.1.1 also had a tag counting performance improvement, which in truth doesn't do much for us but requires a migration
rgarner
added a commit
to alphagov/transition
that referenced
this pull request
May 2, 2014
* This fixes the issue where the Mapping.with_traffic_summary scope would not chain with Mapping.tagged_with, generating invalid SQL when a `count` was required (falling over on `any?` and the like) * While we initially patched AATO ourselves, it turns out a fix was already merged for AATO 3.1.0 (mbleigh/acts-as-taggable-on#417) * 3.1.1 also had a tag counting performance improvement, which in truth doesn't do much for us but requires a migration
rgarner
added a commit
to alphagov/transition
that referenced
this pull request
May 6, 2014
* This fixes the issue where the Mapping.with_traffic_summary scope would not chain with Mapping.tagged_with, generating invalid SQL when a `count` was required (falling over on `any?` and the like) * While we initially patched AATO ourselves, it turns out a fix was already merged for AATO 3.1.0 (mbleigh/acts-as-taggable-on#417) * 3.1.1 also had a tag counting performance improvement, which in truth doesn't do much for us but requires a migration
rgarner
added a commit
to alphagov/transition
that referenced
this pull request
May 6, 2014
* This fixes the issue where the Mapping.with_traffic_summary scope would not chain with Mapping.tagged_with, generating invalid SQL when a `count` was required (falling over on `any?` and the like) * While we initially patched AATO ourselves, it turns out a fix was already merged for AATO 3.1.0 (mbleigh/acts-as-taggable-on#417) * 3.1.1 also had a tag counting performance improvement, which in truth doesn't do much for us but requires a migration
tekniklr
pushed a commit
to tekniklr/acts-as-taggable-on
that referenced
this pull request
Mar 19, 2021
Fix: Let '.count' work when tagged_with is accompanied by a group clause
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give
groupa default of[], which will later evaluate into a no-op by Rails. Previously this would benil, which Rails translates to " AS " in SQL, generating an invalid statement.