Prepare release V10 release #1114
Conversation
seuros
force-pushed
the
prepare-releasev10
branch
from
5b7d875
to
bef3d54
Compare
seuros
force-pushed
the
prepare-releasev10
branch
from
bef3d54
to
39cb826
Compare
chore: remove deprecated method feat: convert tagger to recent syntax
seuros
force-pushed
the
prepare-releasev10
branch
from
39cb826
to
e261357
Compare
| @@ -22,7 +21,7 @@ Gem::Specification.new do |gem| | |||
| gem.post_install_message = File.read('UPGRADING.md') | |||
| end | |||
|
|
|||
| gem.add_runtime_dependency 'activerecord', '>= 6.0', '< 8' | |||
| gem.add_runtime_dependency 'activerecord', '>= 6.1', '< 7.2' | |||
There was a problem hiding this comment.
hi there @seuros! Just out of curiosity, why did you end up changing the < 8 to < 7.2?.
Reading #1110, it seemed to me that the goal was to avoid needing a new release every time a new AR minor was released but I'm not sure if you see any other risks that could come from other "non major" releases.
Thanks!
There was a problem hiding this comment.
Ah, the issue arises when a new major version is released. Devs often upgrade only their Rails/Activerecord, forgetting this gem, assuming it remains compatible.
Then, I start seeing issues reported as 'errors'.
Upon debugging , it frequently turns out that the developers are using a pre-release, the master branch, or even the next major version of Rails.
We can relax the dependency in master btw.
I plan to refactor this gem soon.
There was a problem hiding this comment.
makes sense! thanks for the answer (and the release!)
There was a problem hiding this comment.
Let release a new version.
In this version, we will drop support for unsupported versions of rubies and activerecord.
This will allow to remove any backward compatibility hack that was introduced in the code base.