Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against ruby 2.0 in travis-ci #368

Merged
merged 1 commit into from
Dec 10, 2013
Merged

Conversation

sanemat
Copy link
Contributor

@sanemat sanemat commented Jun 12, 2013

  • Test against ruby 2.0 in travis-ci

@tilsammans
Copy link
Contributor

Why did you remove 1.9.2?

@sanemat
Copy link
Contributor Author

sanemat commented Jun 12, 2013

I think 1.9.2 unmaintained, but removing 1.9.2 may be too much.

@sanemat
Copy link
Contributor Author

sanemat commented Jun 12, 2013

I read Versions 3.x (currently unreleased) are compatible with Ruby 1.9.3+ and Rails 3 and 4., and I understand!

@tilsammans
Copy link
Contributor

Yes, it's good! Thank you.

But I still need to do one last release for 1.8.7 and then I can remove both 1.8.7 and 1.9.2.

So I will keep your pull request open until the last 2.x release goes out, and then merge. I will be in July.

@sanemat
Copy link
Contributor Author

sanemat commented Jun 12, 2013

I add ruby2.0 only.

@bf4
Copy link
Collaborator

bf4 commented Dec 9, 2013

@sanemat Would you mind rebasing / amending this PR to only include sanemat@bc64b9d ?

@sanemat
Copy link
Contributor Author

sanemat commented Dec 9, 2013

@bf4 done:grin:

@bf4
Copy link
Collaborator

bf4 commented Dec 9, 2013

Awesome, will merge once we get tests passing on master :)

@bf4 bf4 merged commit bc64b9d into mbleigh:master Dec 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants