Multiple quoted tags #394
Closed
Multiple quoted tags #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you mind rebasing against master and force-pushing? Thanks |
The regular expression that matches quoted tags matches a delimiter at the start and at the end. Because of this, when matching multiple consecutive quoted tags, the delimiter in between is already matched as end-delimiter for the first tag, and so can no longer serve as start-delimiter for the second tag. By using zero-width lookahead in the regexp, the second delimiter is not consumed.
|
yay :) rebase done cc @thatbettina |
| @@ -22,7 +22,7 @@ Gem::Specification.new do |gem| | |||
| gem.post_install_message = File.read('UPGRADING') | |||
| end | |||
|
|
|||
| gem.add_runtime_dependency 'rails', ['>= 3', '< 5'] | |||
| gem.add_runtime_dependency 'rails', ['>= 3', '< 4'] | |||
|
|
|||
There was a problem hiding this comment.
Tests on master are now passing for Rails 4. Please amend commit and remove this change.
Also, for the future, such a huge change that should have been in a separate commit and highlighted in the PR description.
|
@plexus : Do you rebasing this PR ? I can set it for version 3.2.0 |
|
@seuros I finished this and annotated it myself. Could be better, but is done, at least. |
tekniklr
pushed a commit
to tekniklr/acts-as-taggable-on
that referenced
this pull request
Mar 19, 2021
The regular expression that matches quoted tags matches a delimiter at the start and at the end. Because of this, when matching multiple consecutive quoted tags, the delimiter in between is already matched as end-delimiter for the first tag, and so can no longer serve as start-delimiter for the second tag. By using zero-width lookahead in the regexp, the second delimiter is not consumed. Conflicts: lib/acts_as_taggable_on/tag_list.rb bf4 - Modified and annotated expanded regex Closes mbleigh#394
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug @thatbettina and I came across when tags are entered using quotes, and there are multiple of them after one another, then things don't work as expected.
This PR adds a test case and a fix.
The problem is that the regular expression that matches quoted tags matches a delimiter at the start and at the end. Because of this, when matching multiple consecutive quoted tags, the delimiter in between is already matched as end-delimiter for the first tag, and so can no longer serve as start-delimiter for the second tag.
By using zero-width lookahead in the regexp, the second delimiter is not consumed.
The PR also limits the Rails version again to >= 3.0, < 4.0 because we got unrelated errors when testing on Rails 4, so we couldn't verify the feature works otherwise. This also seems to be why the build on Travis is currently broken.