Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote any references to id in raw sql #399

Closed
wants to merge 1 commit into from
Closed

Conversation

awt
Copy link
Contributor

@awt awt commented Sep 10, 2013

This is a fix for issue #397. I ran the tests to make sure it doesn't break anything in rails 3. I thought about how I could test this, but I couldn't think of a good way to do it without adding db specific sql to the schema.rb file.

@etipton
Copy link

etipton commented Sep 17, 2013

👍 just ran into this issue

@jslag
Copy link

jslag commented Sep 18, 2013

👍

@davidstosik
Copy link

👍
I had the same issue, and I am glad to say that it seems to work with this patch!
Thanks!

@xph
Copy link

xph commented Nov 20, 2013

Sorry to necro this thread. I've been using awt's patch and it solves this issue nicely. Any chance we can merge it into the main repo sometime soon?

@davidstosik
Copy link

I'd like to know too, but it looks like this project has not been active for months...

@bf4
Copy link
Collaborator

bf4 commented Dec 10, 2013

Would you mind rebasing against master and force-pushing?

@davidstosik
Copy link

Hello,
I'm not sure this is the right way to do it, but as I'd like to see that commited quickly, I rebased @awt's commit against master, and submitted a new pull request.
Hope nothing's wrong with that. :)

@bf4
Copy link
Collaborator

bf4 commented Dec 11, 2013

Closed via #431

@bf4 bf4 closed this Dec 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants