Fix missing mattr_accessor require, README test info #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
#404 is an alternative, this is a more immediate fix in terms of review. README update still applies 😝 |
Merged
|
See also #401 |
|
Can you rebase against master and force push? |
|
Rebased. There were unrelated problems with the Travis build previously, not sure if they've been fixed by interim commits, guess we'll find out in a few minutes. |
| @@ -1,5 +1,6 @@ | |||
| require "active_record" | |||
| require "active_record/version" | |||
| require "active_support/core_ext/module" | |||
There was a problem hiding this comment.
This change is no longer necessary due to the full-on require of AS below. However, it would be better to be granular, so I'm ok with this.
|
I'm still having this issue in 2.4.1 and I can't use a git repo to define my dependencies: #404 (comment) |
tekniklr
pushed a commit
to tekniklr/acts-as-taggable-on
that referenced
this pull request
Mar 19, 2021
Update README test instructions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed two extra steps to get test instructions running out of the box 😄