Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build #430

Merged
merged 8 commits into from
Dec 10, 2013
Merged

Fix build #430

merged 8 commits into from
Dec 10, 2013

Commits on Dec 9, 2013

  1. Rails needs to be loaded to meet all gem dependencies

    @bf4
    bf4 committed Dec 9, 2013
    Configuration menu
    Copy the full SHA
    62cc63a View commit details
    Browse the repository at this point in the history

  2. No need to monkey with load path in gem, add to tests

    @bf4
    bf4 committed Dec 9, 2013
    Configuration menu
    Copy the full SHA
    41c16f0 View commit details
    Browse the repository at this point in the history

  3. Use ActiveSupport hooks to lazy-extend/include rails classes

    @bf4
    bf4 committed Dec 9, 2013
    Configuration menu
    Copy the full SHA
    4c77ac6 View commit details
    Browse the repository at this point in the history

  4. Only ActiveSupport actually required, not Rails gem

    @bf4
    bf4 committed Dec 9, 2013
    2 Configuration menu
    Copy the full SHA
    c8dd916 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2013

  1. Update test schema.rb to match current migration 

    However, set force: true and didn't set indices

Fixes test failures for postgresql::

No integer type has byte size 11. Use a numeric with precision 0
instead.

https://travis-ci.org/mbleigh/acts-as-taggable-on/jobs/15196579

see rails/rails#6272
    @bf4
    bf4 committed Dec 10, 2013
    Configuration menu
    Copy the full SHA
    d074e20 View commit details
    Browse the repository at this point in the history

  2. Add .travis.yml bundle cache

    @bf4
    bf4 committed Dec 10, 2013
    Configuration menu
    Copy the full SHA
    1c34142 View commit details
    Browse the repository at this point in the history

  3. Use #detect in Rails to avoid conflicts with AR.find 

    Fixes

https://travis-ci.org/mbleigh/acts-as-taggable-on/jobs/15206376
    @bf4
    bf4 committed Dec 10, 2013
    Configuration menu
    Copy the full SHA
    801e153 View commit details
    Browse the repository at this point in the history

  4. Refactoring; Ensure queried tag is 8bit ASCII 

    Fixes SQLITE3 failures
    @bf4
    bf4 committed Dec 10, 2013
    Configuration menu
    Copy the full SHA
    83a3656 View commit details
    Browse the repository at this point in the history