Add indexes to schema for specs #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the typo fix is already in master. |
|
Rebased to remove typo fix. |
|
👍 |
|
Would you mind rebasing this PR? i want to merge it. |
…e. Also added a quiz method for case insensitive collation. Its important to know when testing case sensitivity.
Some case sensitive specs are not able to run on mysql because the default is case insensitive collation. This combined with a unique index makes adding tags Awesome and awesome impossible because the database sees them as the same thing. To make some of the case sensitive spec pass on mysql, I had to remove the index just for those specs. I added a shared_example that is included where needed.
|
Rebased and al tests passing! |
|
Thank you. |
seuros
added a commit
that referenced
this pull request
Mar 21, 2014
…pecs Add indexes to schema for specs
tekniklr
pushed a commit
to tekniklr/acts-as-taggable-on
that referenced
this pull request
Mar 19, 2021
…a-for-specs Add indexes to schema for specs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A unique index on the name field was added to the migration, but not the schema file. I added the indexes to the schema file so the unique index on name is available during specs. This makes it a bit easier to demonstrate which features work and which do not when the unique index is enabled.