Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use group rather than distinct or .uniq when using tagged_with(any:true). Fixes PostgreSQL errors #496

Merged
merged 1 commit into from
May 1, 2014

Commits on Apr 23, 2014

  1. fix bug mbleigh#506 - .uniq breaks with pg and json columns

    fix bug mbleigh#506 - .uniq breaks with pg and json columns
    
    updated specs for 'select distinct' and pg issues
    
    * new model/table with a json column for postgresql specific testing
    * add tests for explicit distinct in a select and for all queries to
      test if tagged_with adds a distinct clause on the query.
      http://github.com/mbleigh/acts-as-taggable-on/issues/357
    * add tests for taggable_model_with_json
    * exclude test should sort the array result and expected array.
      PostgreSQL won't always return the two expected results in
      the expected order so the test failed intermittently.
    
    use group vs distinct when options[:any] is true
    
    update CHANGELOG
    
    check pg version and only use json if >=9.2
    
    move change to master section
    
    move table with json to spec/internal/db/schema.rb
    leklund committed Apr 23, 2014
    Configuration menu
    Copy the full SHA
    9b3e3cb View commit details
    Browse the repository at this point in the history