Rename Compatibility methods to reduce chance of conflicts #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, FlagShihTzu also has a parse_options method mixed into ActiveRecord::Base
|
This is probably a breaking change .. |
|
I don't think it's a breaking change if it's not part of the public api. I'm ok with the better naming, or a refactor to use an object.... |
seuros
added a commit
that referenced
this pull request
Apr 27, 2014
Rename Compatibility methods to reduce chance of conflicts
tekniklr
pushed a commit
to tekniklr/acts-as-taggable-on
that referenced
this pull request
Mar 19, 2021
Rename Compatibility methods to reduce chance of conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi - I ran into problems with AATO because I also use FlagShihTzu, which also has a parse_options method mixed into ActiveRecord::Base. I renamed a couple of methods that sounded ambiguously named - WDYT?