Fixed generated SQL for tagged_with :any

[stiff]

Closes #519.

[seuros]

Thank you. Now the tests are failing.

[stiff]

Agree, it's not good but I needed an urgent fix, maybe later I'll take a look at the tests

[stiff]

Fixed wrong merging, now two tests failing:

• one which abuses the forgiving treatment of invalid SQL by Sqlite and Mysql, which should be removed (or group by should be added explicitly). But it signifies that the public api has slightly changed, which should be noted and version should be bumped?
• another which groups by unexistent column, and the only reason it was not failing before is because the column with same name occasionally appeared in join'd table.

[seuros]

That work only in PG .

[stiff]

What exactly doesn't work and in which DB? Can you provide the error message, or something more specific

[seuros]

Nevermind, i used the wrong database. Sorry.

[seuros]

If the tests are invalid, we should remove/fix them, i think we can fix correct the api if we don't remove the feature. WDYT ?

cc @bf4

[stiff]

Take a look at latest (7af0ed3) commit: it fixes the test, and implements :order_by_matching_tag_count

The 'not covered by test' in 15ab99d refers only to sqlite3, see 7af0ed3 travis build results. Very strange.

[seuros]

@stiff can you squash your commits ? ping me when it done.

[stiff]

Done

[seuros]

Thank you