Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#623: solve matching of binary-encoded strings with MySql (via rake rule or initializer setting) #634

Merged
merged 3 commits into from
Mar 1, 2015

Conversation

rikettsie
Copy link
Contributor

No description provided.

@rikettsie rikettsie changed the title #623: added fixes and a test for binary-encoded strings with MySql #623: solve matching of binary-encoded strings with MySql (via rake rule or initializer setting) Feb 27, 2015
@rikettsie
Copy link
Contributor Author

@seuros I cleaned up things a little bit adding a rake rule (or optionally a configuration setting) and updated the README.md consistently.

@seuros
Copy link
Collaborator

seuros commented Mar 1, 2015

could you squash your commits ?

@rikettsie
Copy link
Contributor Author

Of course @seuros , commits squashed.

@seuros
Copy link
Collaborator

seuros commented Mar 1, 2015

There is 20 commits in this PR.

@rikettsie
Copy link
Contributor Author

@seuros i finally could squash the commits

shared_examples_for 'without unique index' do
prepend_before(:all) { AddMissingUniqueIndices.down }
prepend_before(:all) do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you change this ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I implemented the patch as a migration I added the new one there, but then, after changing perspective (as the migration was an "execute", not tracked in the schema) I removed both migration and its call in the tag_spec.rb. Thus that changed. But I can reset the previous line.

@seuros
Copy link
Collaborator

seuros commented Mar 1, 2015

for some reason, i can't merge it. can you rebase ?

@rikettsie
Copy link
Contributor Author

@seuros master seems ok now :-)

rikettsie and others added 2 commits March 1, 2015 21:45
added migration and rake task

added rake rule and a config parameter to force binary collation (MySql)

Added test for binary string collation

included migration in test

added self to migration

moved binary collation migration to 'without unique index' context

moved binary collation parameter from migration to app configuration

(typo) removed import

(typo) missing Configuration class name

force_binary_collation change can be set by MySql users only

(typo) method name using_mysql?

when force_binary_collation is false, strict_case_match is not touch

force_binary_collation not used in context without_unique_index

updated README and simplified rake test

rake task calls Configuration function

updated README

Gemfile cleaned

cleaned READEME.md

Added test for binary string collation

(typo) removed import

(typo) method name using_mysql?

when force_binary_collation is false, strict_case_match is not touch

force_binary_collation not used in context without_unique_index

Gemfile cleaned

updated CHANGELOG

added migration and rake task

Add context constraint to find_related_* methods. Fixes mbleigh#628

version bump

added rake rule and a config parameter to force binary collation (MySql)

added rake rule and a config parameter to force binary collation (MySql)

applied changes

added migration and rake task
seuros added a commit that referenced this pull request Mar 1, 2015
#623: solve matching of binary-encoded strings with MySql (via rake rule or initializer setting)
@seuros seuros merged commit 4942ea2 into mbleigh:master Mar 1, 2015
tekniklr pushed a commit to tekniklr/acts-as-taggable-on that referenced this pull request Mar 19, 2021
mbleigh#623: solve matching of binary-encoded strings with MySql (via rake rule or initializer setting)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants