Add rspecs to tagging spec #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you squash your commits ? |
|
Hi Seuros, Ok I will squash them |
Add rspec for owned_by scope Add rspec for owned_by scope a tagging should belong to a specific user Add rspec test for owned by scope a tagging should belong to a specific user Add rspec test for by_context tagging scope a tagging should be found by context Add rspec test for by_contexts tagging scope taggings can be found by contexts Add rspec test for not_owned tagging scope not_owned scope should found the taggings that do not have owner Refactor owned_by rspec test for tagging_rspec Refactor by_contexts rspec test for tagging_rspec
Update changelog Update changelog
pcupueran
force-pushed
the
add_rspecs_to_tagging_spec
branch
from
0cf25c3
to
9aca2f1
Compare
|
Awesome 💚 |
|
Well done Patty! |
|
Nice addition Patty! |
|
Thank you! |
tekniklr
pushed a commit
to tekniklr/acts-as-taggable-on
that referenced
this pull request
Mar 19, 2021
Add rspecs to tagging spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I completed the test that were pending in the tagging_spec file. This helps to maintain the code