Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Given a resource: get all tags by owner and get owner tags for multiple contexts #771

Merged
merged 3 commits into from
Aug 7, 2016

Conversation

brilyuhns
Copy link
Contributor

@brilyuhns brilyuhns commented Jul 21, 2016

This allows to

  • Retrieve all the tags to a resource by an owner in one go
  • Retrieve owner tags by multiple context in one go

@brilyuhns brilyuhns force-pushed the add_tags_by_owner branch 2 times, most recently from c423d01 to 2cfc7d1 Compare July 21, 2016 12:54
@brilyuhns brilyuhns changed the title Methods to get all tags by owner and get owner tags for multiple contexts Given a resource: get all tags by owner and get owner tags for multiple contexts Jul 21, 2016
@seuros
Copy link
Collaborator

seuros commented Jul 21, 2016

LGTM

@krzysiek1507 @rbritom ^^

@krzysiek1507
Copy link
Contributor

@brilyuhns could you please add specs?

@brilyuhns
Copy link
Contributor Author

Hey thanks for considering this. I will write some specs soon and update the PR.

@seuros
Copy link
Collaborator

seuros commented Aug 6, 2016

@brilyuhns it seem that either your git client or github is not configured correctly.
The commits don't link to your profile.
I can merge, but your profile won't show up in the contributors part.

@brilyuhns
Copy link
Contributor Author

@seuros I have fixed the author for the commits. Please take a look.

@seuros seuros merged commit 67cb90a into mbleigh:master Aug 7, 2016
@seuros
Copy link
Collaborator

seuros commented Aug 7, 2016

Thank you @brilyuhns

@brilyuhns
Copy link
Contributor Author

Thanks for the gem :)

tekniklr pushed a commit to tekniklr/acts-as-taggable-on that referenced this pull request Mar 19, 2021
Given a resource: get all tags by owner and get owner tags for multiple contexts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants