Fixes #712 (incompatibility with ActiveRecord::Sanitization#quoted_id) #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 25, 2016 15:10
…oted_id). Removes use of the ActiveRecord::Sanitization#quote_value, which was just a convenience wrapper for connection.quote. Its signature changed in Rails 5.0.0, and it has been removed completely in Rails master. See: - rails/rails@268ee64 - rails/rails@12a42f7
|
My application was also affected by this issue. This PR solves it for me, and none of my application's specs failed, so it looks like it doesn't introduce any regressions. The only thing I could see adding to it is a spec that could prevent this regression from happening again in the future. |
|
@gmcnaughton Thank you |
|
Thanks @seuros, happy to help! |
tekniklr
pushed a commit
to tekniklr/acts-as-taggable-on
that referenced
this pull request
Mar 19, 2021
Fixes mbleigh#712 (incompatibility with ActiveRecord::Sanitization#quoted_id)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes use of the
ActiveRecord::Sanitization#quote_value, which wasa convenience wrapper for
self.class.connection.quote.The convenience method's signature changed in Rails 5.0.0, and it has now been removed completely from Rails master.
Fixes #712
See: