build: remove gcc attribute specificers

Attribute specificers, e.g. __attribute__
((attr)), are specific to gcc. We only had one but
were considering adding others. We'd rather not be
bound to gcc in this way.

Remove attribute suggestion flags from our
makefile, and clean our makefile up a bit.

See https://gcc.gnu.org/onlinedocs/gcc/Attribute-Syntax.html

Makefile

@@ -1,4 +1,4 @@
-# Make manual: hhttps://www.gnu.org/software/make/manual/make.html
+# Make manual: https://www.gnu.org/software/make/manual/make.html
 # GCC Options: https://gcc.gnu.org/onlinedocs/gcc/Option-Summary.html
 
 # mmv
@@ -14,7 +14,6 @@ bin_dir = $(prefix)/bin
 man_dir = $(prefix)/man/man1
 
 src_dir = src
-inc_dir = inc
 test_dir = test
 debug_dir = debug
 build_dir = build
@@ -31,8 +30,7 @@ w-arith = -Wdouble-promotion -Wfloat-equal
 w-basic = -pedantic -Wall -Wextra
 w-extra = -Wcast-align=strict -Wconversion -Wpadded -Wshadow -Wstrict-prototypes -Wvla
 w-fmt = -Wformat=2 -Wformat-overflow=2 -Wformat-truncation
-w-sgst = -Wsuggest-attribute=const -Wsuggest-attribute=malloc -Wsuggest-attribute=noreturn
-warn = $(w-basic) $(w-extra) $(w-arith) $(w-fmt) $(w-sgst)
+warn = $(w-basic) $(w-extra) $(w-arith) $(w-fmt)
 
 CFLAGS = $(warn) $(optim)
 
@@ -70,6 +68,7 @@ debug_clean:
 	rm -rf $(build_dir)
 	rm debug_$(bin_name)
 
+
 # install target for "sudo make install"
 install:
 	$(NORMAL_INSTALL)

src/mmv.c

@@ -22,7 +22,7 @@ int write_strarr_to_tmpfile(struct Set *map, char tmp_path_template[])
 	return 0;
 }
 
-FILE *__attribute__((malloc)) open_tmpfile_fptr(char *tmp_path)
+FILE *open_tmpfile_fptr(char *tmp_path)
 {
 	int tmp_fd = mkstemp(tmp_path);
 	if (tmp_fd == -1)

src/mmv.h

@@ -45,7 +45,7 @@ int write_strarr_to_tmpfile(struct Set *map, char tmp_path_template[]);
  *
  * @return file pointer to opened path
  */
-FILE *__attribute__((malloc)) open_tmpfile_fptr(char *tmp_path);
+FILE *open_tmpfile_fptr(char *tmp_path);
 
 /**
  * @brief gets the user's $EDITOR env variable and opens temp file with it