Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

US-like TxParamSetupReq processing is erroneous #385

Closed
terrillmoore opened this issue Aug 24, 2019 · 0 comments
Closed

US-like TxParamSetupReq processing is erroneous #385

terrillmoore opened this issue Aug 24, 2019 · 0 comments
Assignees
Labels

Comments

@terrillmoore
Copy link
Member

terrillmoore commented Aug 24, 2019

TxParamSetupReq as implemented for us-like regions has a few problems.

  1. It miscomputes the base channel for a change group change; if the host asks to disable all 500k channels, it will instead disable 125k channels 0..15, causing an assert the next time nextTx is called.
  2. nextTx() should try 125k channels and lowering datarate (or 500k channels and raising datarate).
  3. It doesn't check the feasibility of the selected data rate given the effective set of enabled channels
  4. It doesn't include the need for minimum number of 125k channels in its effectiveness decision.

The US compliance tests do things like turning off all 125kHz channels and setting DR to DR1 -- not feasible unless you have some number of 125kHz channels. In this case, we're supposed to reject the request.

@terrillmoore terrillmoore self-assigned this Aug 24, 2019
terrillmoore added a commit that referenced this issue Aug 24, 2019
Fix #385: correct TxSetupParamReq processing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant