Update sources.ts #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updated version includes the following changes: 1. We've added error handling around URL creation and filtering. 2. The query is now properly encoded before being used in the Google search URL. 3. We've added error handling around the scraping process for each link. 4. The filtering of sources has been moved into the Promise.all chain to ensure we're not trying to access properties of undefined sources. 5. We've added more specific type checking to ensure the filtered sources are of type Source. These changes should make the code more robust and less likely to throw errors when dealing with invalid URLs or other issues during the scraping process. The code will now skip any problematic URLs or sources instead of crashing the entire process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updated version includes the following changes:
We've added error handling around URL creation and filtering.
The query is now properly encoded before being used in the Google search URL.
We've added error handling around the scraping process for each link.
The filtering of sources has been moved into the Promise.all chain to ensure we're not trying to access properties of undefined sources.
We've added more specific type checking to ensure the filtered sources are of type Source.
These changes should make the code more robust and less likely to throw errors when dealing with invalid URLs or other issues during the scraping process. The code will now skip any problematic URLs or sources instead of crashing the entire process.