ACAS-712: HRP project type support #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⬆️ Upmerge release/2023.3.x to release/2023.4.x
⬆️ Upmerge release/2023.3.x to release/2023.4.x
brianbolt
commented
Dec 6, 2023
brianbolt
requested review from
bffrost,
iamanandkr,
dalejerikson and
hhan-schrodinger
brianbolt
changed the title
iamanandkr
approved these changes
Dec 8, 2023
bffrost
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
LGTM, I greatly appreciate both the code comments and the self-review you've given @brianbolt . Left a few questions and nits about code comments but this looks correct to me.
modules/ServerAPI/src/server/python/acas_ldclient/acasldclient.py
Outdated
Show resolved
Hide resolved
|
I tested the behaviour in K8s, both ACAS-704 and ACAS-712 are now working as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
ACAS-712
How Has This Been Tested?
Ran new acasclient tests with base ACAS system.
To HRP project types, modified the default CustomerSpecificServerFunctions.coffee to include a "type" field.
I also modified the acasclient test messages to match those produced when project types are enabled
Finally, I verified that the final test in acasclient
(Allowed) Unrestricted experiment proj1 with lot restricted proj2becomes a fail because the lot project is hyper restricted.