Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACAS-318: Delete file on Load another #1144

Merged
merged 1 commit into from
Feb 29, 2024
Merged

ACAS-318: Delete file on Load another #1144

merged 1 commit into from
Feb 29, 2024

Conversation

brianbolt
Copy link
Contributor

@brianbolt brianbolt commented Feb 29, 2024 •
edited
Loading

Description

  • Fixes issue where file is not deleted on "Load Another" by programmatically clicking the delete button.
  • This was kind of a deep issue and there was a previous "hack" found on other modules that did this exact same thing so I went with this solution.

Related Issue

ACAS-318

How Has This Been Tested?

demo

bffrost
bffrost approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@bffrost bffrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I laughed out loud at what the fix is. LGTM

@brianbolt brianbolt merged commit 84876c6 into release/2024.1.x Feb 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bffrost bffrost bffrost approved these changes

@dalejerikson dalejerikson Awaiting requested review from dalejerikson

@hhan-schrodinger hhan-schrodinger Awaiting requested review from hhan-schrodinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianbolt @bffrost