ACAS-764: Clean up cmpdreg exported search results > 24 hours old #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianbolt
commented
Apr 16, 2024
| @@ -927,6 +927,7 @@ exports.exportSearchResults = (req, resp) -> | |||
| serverUtilityFunctions.ensureExists exportedSearchResults, 0o0744, (err) -> | |||
| if err? | |||
| console.log "Can't find or create exportedSearchResults folder: " + exportedSearchResults | |||
| console.error err | |||
There was a problem hiding this comment.
outside pr scope: I wanted this to print the actual error. I initial had a weird local setup that was producing and an error and I added this line to debug the issue.
brianbolt
changed the title
bffrost
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
ACAS-764
How Has This Been Tested?
Basic
Exported some search results and then ran:
touch -d "25 hours ago" privateUploads/exportedSearchResults/*.sdfVerified the files were cleaned up
Folder
Added a folder to exportedSearchResults and verified this did not produce and error and was skipped
Added a purposeful error inside the
cleanUpExportedSearchResultsfunction and verified that the exportSearchResults function continue to work (just to make sure this doesn't break export if it happens to error for some reason.Deployed this to a stage server with a lot of old exported search results and verified it cleaned up old files when I exported search results.