Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACAS-736: Append new experiment endpoints to protocol endpoints #1177

Merged
merged 2 commits into from
Jun 17, 2024
Merged

ACAS-736: Append new experiment endpoints to protocol endpoints #1177

merged 2 commits into from
Jun 17, 2024

Conversation

brianbolt
Copy link
Contributor

@brianbolt brianbolt commented Jun 17, 2024 •
edited
Loading

Description

  • Returns a list of non-matching endpoints when comparing protocol and experiment endpoints and then adds new endpoints to the protocol by adding additional metadata_column order states.

Related Issue

ACAS-736

How Has This Been Tested?

  • Manually uploaded an experiment
  • Changed an endpoint name and re-uploaded the experiment and verified the endpoint was added to the protocol and upon subsequent uploads did not receive a warning about the endpoint.

bffrost
bffrost approved these changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@bffrost bffrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for a typo. I see you're expanding the return values fo that validateExperimentColumns function, collecting non matching rows, then you've added a new function to append the new endpoints to the protocol (only in non-dryrun)

modules/GenericDataParser/src/server/generic_data_parser.R Outdated Show resolved Hide resolved
@brianbolt brianbolt merged commit 18fe806 into release/2024.2.x Jun 17, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bffrost bffrost bffrost approved these changes

@hhan-schrodinger hhan-schrodinger Awaiting requested review from hhan-schrodinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianbolt @bffrost