Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

739-auto-sequence-thing-label #740

Merged
merged 1 commit into from
Apr 27, 2021
Merged

739-auto-sequence-thing-label #740

merged 1 commit into from
Apr 27, 2021

Conversation

brianbolt
Copy link
Contributor

No description provided.

@brianbolt brianbolt requested a review from bffrost April 26, 2021 23:53
bffrost
bffrost approved these changes Apr 27, 2021
View reviewed changes
Copy link
Collaborator

@bffrost bffrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will look for this isAutoLabel attribute in the next PR

modules/ServerAPI/src/client/Thing.coffee
@@ -217,6 +220,13 @@ class Thing extends Backbone.Model
newLabel.set key: dLabel.key
newLabel.set preferred: dLabel.preferred

# If auto label is set then use it (evaluating only to true if set to true)
# Otherwise set the deafault to false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Typo in deafault

@brianbolt brianbolt merged commit 129a742 into release/1.13.6 Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bffrost bffrost bffrost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianbolt @bffrost