-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #750 Created thing basic validate and save form #751
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Clean and easy to follow.
Longer term might be good to add a comment block at the top describing what a form that extends this BasicThingValidateAndSave should pass at various phases, but I think it's too soon to add that documentation.
@$('.bv_validateStatusDropDown').modal | ||
backdrop: "static" | ||
@$('.bv_validateStatusDropDown').modal "show" | ||
dataToPost = @prepareDataToPost(true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted - dryRun: true
data = | ||
user: user | ||
dryRunMode: dryRun | ||
$.extend(data,@additionalData) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so @additionalData
is the LsThing
loadAnother: => | ||
#TODO This is bad style, but the LSFileInputController has no API for deleting and resetting | ||
@showInputPhase() | ||
#TODO Why does this need a delay to work? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if these TODOs are still relevant
@$('.bv_preProcessorHTMLSummary').html(preProcessorSummaryHTML) | ||
@$('.bv_preProcessorHTMLSummary').show() | ||
|
||
showCSVPreview: (csv) -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat feature.
No description provided.