Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save original file name in comments when saving ls through ls file chooser #790

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Save original file name in comments when saving ls through ls file chooser #790

merged 1 commit into from
Jul 28, 2021

Conversation

brianbolt
Copy link
Contributor

Fixes #789

@brianbolt brianbolt requested a review from bffrost July 28, 2021 18:20
@brianbolt
Copy link
Contributor Author

I verified this worked on both ls blob and ls file values. In both cases the original file name was maintained.

bffrost
bffrost approved these changes Jul 28, 2021
View reviewed changes
Copy link
Collaborator

@bffrost bffrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianbolt brianbolt merged commit 4056e67 into release/1.13.6 Jul 28, 2021
@bffrost bffrost mentioned this pull request Jul 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bffrost bffrost bffrost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Save original file name in comments when saving ls through ls file chooser
2 participants
@brianbolt @bffrost