Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACAS SAML fails against Azure AD #808

Merged
merged 2 commits into from
Oct 20, 2021
Merged

ACAS SAML fails against Azure AD #808

merged 2 commits into from
Oct 20, 2021

Conversation

brianbolt
Copy link
Contributor

Fixes #807

@bffrost
Copy link
Collaborator

bffrost commented Oct 20, 2021

Have we tested that this doesn't break Okta auth? Just wondering whether this is safe to hardcode or should be a config.

@brianbolt
Copy link
Contributor Author

No, not specifically Okta. I'll check on that and report back.

@brianbolt
Copy link
Contributor Author

Too much effort to setup dev environment against okta so I just made it configurable with the default being true

bffrost
bffrost approved these changes Oct 20, 2021
View reviewed changes
Copy link
Collaborator

@bffrost bffrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianbolt brianbolt merged commit dbed380 into release/1.13.6 Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bffrost bffrost bffrost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ACAS SAML fails against Azure AD
2 participants
@brianbolt @bffrost