Add - to allowed characters for inline HTML
#92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows things like data attributes to work properly in inline HTML.
| @@ -248,6 +248,7 @@ - (NSRange)_parseNameWithScanner:(MMScanner *)scanner | |||
| { | |||
| NSMutableCharacterSet *nameSet = [NSMutableCharacterSet alphanumericCharacterSet]; | |||
| [nameSet addCharactersInString:@":"]; | |||
| [nameSet addCharactersInString:@"-"]; | |||
There was a problem hiding this comment.
Could you add this in the previous call to addCharactersInString: instead of adding a second call?
|
Thanks for the pull request! Just the one nit, otherwise things look great! |
|
👍 — updated the PR. |
|
Thank you! ✨ |
mdiep
added a commit
that referenced
this pull request
Dec 25, 2015
…e-html Add `-` to allowed characters for inline HTML
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows things like data attributes to work properly in inline HTML.