Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set preview->false for features not in Safari 16.2 #18530

Closed
wants to merge 1 commit into from
Closed

Set preview->false for features not in Safari 16.2 #18530

wants to merge 1 commit into from

Conversation

queengooborg
Copy link
Collaborator

This PR changes preview to false for features that were not released in Safari 16.2. Results come from the mdn-bcd-collector project (v7.1.2) at https://mdn-bcd-collector.appspot.com.

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jan 4, 2023
@Elchi3
Copy link
Member

Elchi3 commented Jan 4, 2023

I assume a lot of these values came from #18268?
Should they be false or stay preview because maybe they make it in the next version of Safari? What about running the collector against Safari Technical Preview 160?

Elchi3
Elchi3 requested changes Jan 4, 2023
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked: PerformanceServerTiming is not an object in Safari 16.2. but it is there in STP 160 so preview is correct. I didn't check further but likely more problems like this exist.

@queengooborg
Copy link
Collaborator Author

After checking these features in STP 160, I found out two things:

  1. Every single feature that's set to preview now is actually still valid.
  2. Apparently, the STP releases are two minor versions ahead; STP 160 reports as Safari 16.4. This is unlike pre-Safari 15 STP versions, but given the change in release cycle, this makes sense.

I will be closing this issue accordingly.

@queengooborg queengooborg deleted the api/safari/preview branch January 5, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 requested changes

Assignees
No one assigned
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@queengooborg @Elchi3