Mark NavigatorID members standard; most deprecated #6612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change consistently marks all members of NavigatorID as standard — because they are all in fact defined in the HTML spec. And it marks almost all as deprecated — because almost all of them are required to return either a constant (and so, useless) value, or else are defined to *optionally* return a constant value, but are strongly encouraged by the spec to do return a constant value. The only exceptions are: * navigator.userAgent, defined to return a non-constant value * navigator.vendor, defined to return a value depending on which engine the browser is running; either "Google Inc.", "Apple Computer, Inc.", or the empty string (for Gecko) https://html.spec.whatwg.org/multipage/#dom-navigator-useragent Fixes #6567
github-actions
bot
added
the
data:api 🐇
foolip
approved these changes
Aug 31, 2020
| @@ -1572,7 +1572,7 @@ | |||
| }, | |||
| "status": { | |||
| "experimental": false, | |||
| "standard_track": false, | |||
| "standard_track": true, | |||
There was a problem hiding this comment.
Confirmed: https://html.spec.whatwg.org/multipage/system-state.html#dom-navigator-oscpu
(But required to only be supported in Gecko.)
| @@ -1736,8 +1736,8 @@ | |||
| }, | |||
| "status": { | |||
| "experimental": false, | |||
| "standard_track": false, | |||
| "deprecated": false | |||
| "standard_track": true, | |||
There was a problem hiding this comment.
| @@ -2226,8 +2226,8 @@ | |||
| }, | |||
| "status": { | |||
| "experimental": false, | |||
| "standard_track": false, | |||
| "deprecated": false | |||
| "standard_track": true, | |||
There was a problem hiding this comment.
Confirmed: https://html.spec.whatwg.org/multipage/system-state.html#dom-navigator-vendorsub
(Must return the empty string.)
| @@ -91,7 +91,7 @@ | |||
| "status": { | |||
| "experimental": false, | |||
| "standard_track": true, | |||
| "deprecated": false | |||
| "deprecated": true | |||
There was a problem hiding this comment.
| @@ -139,7 +139,7 @@ | |||
| "status": { | |||
| "experimental": false, | |||
| "standard_track": true, | |||
| "deprecated": false | |||
| "deprecated": true | |||
There was a problem hiding this comment.
| @@ -187,7 +187,7 @@ | |||
| "status": { | |||
| "experimental": false, | |||
| "standard_track": true, | |||
| "deprecated": false | |||
| "deprecated": true | |||
There was a problem hiding this comment.
| @@ -239,7 +239,7 @@ | |||
| "status": { | |||
| "experimental": false, | |||
| "standard_track": true, | |||
| "deprecated": false | |||
| "deprecated": true | |||
There was a problem hiding this comment.
| @@ -287,7 +287,7 @@ | |||
| "status": { | |||
| "experimental": false, | |||
| "standard_track": true, | |||
| "deprecated": false | |||
| "deprecated": true | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change consistently marks all members of
NavigatorIDas standard — because they are all in fact defined in the HTML spec. And it marks almost all as deprecated — because almost all of them are required to return either a constant (and so, useless) value, or else are defined to optionally return a constant value, but are strongly encouraged by the spec to do return a constant value.The only exceptions are:
navigator.userAgent, defined to return a non-constant valuenavigator.vendor, defined to return a value depending on which engine the browser is running; eitherGoogle Inc.,Apple Computer, Inc., or the empty string (for Gecko)https://html.spec.whatwg.org/multipage/#dom-navigator-useragent
Fixes #6567