Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inaccuracies in extension CSP documentation #20437

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

Rob--W
Copy link
Member

@Rob--W Rob--W commented Sep 8, 2022

@Rob--W Rob--W requested a review from a team as a code owner September 8, 2022 18:39
@github-actions github-actions bot added Content:Other Any docs not covered by another "Content:" label Content:WebExt WebExtensions docs labels Sep 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

Copy link
Contributor

@rebloor rebloor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits, not all related to your changes, suggested changes

- Document content script CSP ( bugzil.la/1581611 ).
- Clarify what CSP covers (not just `<script>`).
- Clarify role of object-src ( bugzil.la/1766881 , crbug.com/1320785 ).
- Clarify what is considered a secure source for MV2 and MV3.
- Remove localhost ( bugzil.la/1789751 ).
- Remove "valid" examples that are actually not valid MV3 examples.
- Add formatting to style invalid examples as "example-bad".
@rebloor
Copy link
Contributor

rebloor commented Sep 13, 2022

@Rob--W are you happy if I merge or do you want to review from @mixedpuppy too?

@Rob--W Rob--W merged commit aac7656 into mdn:main Sep 22, 2022
himanshugarg pushed a commit to himanshugarg/content that referenced this pull request Sep 27, 2022
- Document content script CSP ( bugzil.la/1581611 ).
- Clarify what CSP covers (not just `<script>`).
- Clarify role of object-src ( bugzil.la/1766881 , crbug.com/1320785 ).
- Clarify what is considered a secure source for MV2 and MV3.
- Remove localhost ( bugzil.la/1789751 ).
- Remove "valid" examples that are actually not valid MV3 examples.
- Add formatting to style invalid examples as "example-bad".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Other Any docs not covered by another "Content:" label Content:WebExt WebExtensions docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants