Version number simplification for MV3 #21699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Content:Other
|
Preview URLs
External URLs (2)URL:
(this comment was updated 2022-10-31 22:48:09.039885) |
rebloor
commented
Oct 21, 2022
files/en-us/mozilla/add-ons/webextensions/manifest.json/version/format/index.md
Outdated
Show resolved
Hide resolved
rebloor
commented
Oct 23, 2022
files/en-us/mozilla/add-ons/webextensions/manifest.json/version/index.md
Outdated
Show resolved
Hide resolved
willdurand
reviewed
Oct 25, 2022
files/en-us/mozilla/add-ons/webextensions/manifest.json/version/format/index.md
Show resolved
Hide resolved
files/en-us/mozilla/add-ons/webextensions/manifest.json/version/format/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mozilla/add-ons/webextensions/manifest.json/version/format/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mozilla/add-ons/webextensions/manifest.json/version/index.md
Outdated
Show resolved
Hide resolved
Rob--W
reviewed
Oct 28, 2022
files/en-us/mozilla/add-ons/webextensions/manifest.json/version/format/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mozilla/add-ons/webextensions/manifest.json/version/format/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mozilla/add-ons/webextensions/manifest.json/version/format/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mozilla/add-ons/webextensions/manifest.json/version/format/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mozilla/add-ons/webextensions/manifest.json/version/format/index.md
Outdated
Show resolved
Hide resolved
Rob--W
reviewed
Oct 28, 2022
files/en-us/mozilla/add-ons/webextensions/manifest.json/version/format/index.md
Show resolved
Hide resolved
files/en-us/mozilla/add-ons/webextensions/manifest.json/version/index.md
Outdated
Show resolved
Hide resolved
willdurand
approved these changes
Oct 31, 2022
files/en-us/mozilla/add-ons/webextensions/manifest.json/version/index.md
Outdated
Show resolved
Hide resolved
Rob--W
reviewed
Oct 31, 2022
There was a problem hiding this comment.
The last update didn't cover #21699 (comment). Was that intentional or pending clarification?
Other than that and the comments here, it's basically ready to merge.
files/en-us/mozilla/add-ons/webextensions/manifest.json/version/format/index.md
Show resolved
Hide resolved
files/en-us/mozilla/add-ons/webextensions/manifest.json/version/index.md
Outdated
Show resolved
Hide resolved
|
@Rob--W I believe I've addressed all your feedback. I'll merge tomorrow if you have no further feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the information about version number format to provide for the simplified format for MV3 extensions in Firefox 108 and later.
Related issues and pull requests
Addresses the documentation needs of Bug 1793925 Warn about complex versioning formats used in manifest