Update dart version and checkout #367
Conversation
brunoocasali
force-pushed
the
update-tests
branch
2 times, most recently
from
03787c7
to
202b30d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #367 +/- ##
==========================================
- Coverage 82.25% 81.85% -0.40%
==========================================
Files 57 57
Lines 1347 1345 -2
==========================================
- Hits 1108 1101 -7
- Misses 239 244 +5 ☔ View full report in Codecov by Sentry. |
brunoocasali
force-pushed
the
update-tests
branch
2 times, most recently
from
bb8a90c
to
8b9f752
Compare
brunoocasali
force-pushed
the
update-tests
branch
from
8b9f752
to
706302e
Compare
| @@ -131,8 +127,4 @@ class TestMeiliSearchClient extends MeiliSearchClient { | |||
| ), | |||
| ); | |||
| } | |||
|
|
|||
| Future<void> _deleteTasksForDeletedIndexes(List<String> indexes) async { | |||
There was a problem hiding this comment.
@ahmednfwela, this code was causing some intermittent trouble in the CI. You can see some examples here:
- https://github.com/meilisearch/meilisearch/actions/runs/7265526184/job/19822841536
- https://github.com/meilisearch/meilisearch-dart/actions/runs/7276040412
- https://github.com/meilisearch/meilisearch-dart/actions/runs/7275849120
- https://github.com/meilisearch/meilisearch-dart/actions/runs/7275802328
- https://github.com/meilisearch/meilisearch-dart/actions/runs/7275359927
Although keeping track of used resources is very clever, it isn't worth it for two reasons. First, it is hard to understand where the error comes from (due to the stack trace dart left behind). And second, because you should always clean up the state before you run the tests, not after.
I like this article that highlights why this should be followed as a good practice: https://docs.cypress.io/guides/references/best-practices#Using-after-Or-afterEach-Hooks I've been applying this concept for a long time, and it helps a lot.
|
@ahmednfwela I'm going to merge this because it is breaking the workflow in the engine, but I think you'll want to do a FUP fix about the things I said before! Thanks a lot for your help and see you soon! |
brunoocasali
added
the
maintenance
376: Update version for the next release (v0.16.0) r=curquiza a=meili-bot _This PR is auto-generated._ The automated script updates the version of meilisearch-dart to a new version: "v0.16.0" --- Parr of the work of #375 --- This version introduces features released on Meilisearch v1.7.0 🎉 Check out the changelog of [Meilisearch v1.7.0](https://github.com/meilisearch/meilisearch/releases/tag/v1.7.0) for more information on the changes. ##⚠️ Breaking changes * `scoreDetails` feature is not experimental anymore. You can directly use `showRankingScoreDetails` during a search without activating the experimental feature 🎉 ## 🚀 Enhancements * Add text separators (#379) ahmednfwela ## ⚙️ Maintenance/misc * Create code samples from code, a.k.a. code excerpts (#358) ahmednfwela * Update dart version and checkout (#367) brunoocasali * fix ci steps (#378) ahmednfwela * docs: Add readme section about dio (#380) ahmednfwela Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com> Co-authored-by: Ahmed Fwela <63286031+ahmednfwela@users.noreply.github.com> Co-authored-by: Clémentine U. - curqui <clementine@meilisearch.com>
Update tests.yml to update action versions & Update dart to latest