Improve calculation of light colors #1967
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes lugia on the soul silver title screen
|
messing with a test rom reveals that there's definitely still something ever so slightly off in the color calcs |
shouldn't need to check that every time, since the variable shouldn't be able to overflow
nadiaholmquist
force-pushed
the
master
branch
from
10c70eb
to
a7575ec
Compare
Should it cap at all? Can vtx colors overflow...?
Jaklyy
force-pushed
the
lighting-test
branch
2 times, most recently
from
4f45a03
to
5ae9ed6
Compare
fixes some minor inaccuracies
fixes a few off by ones - finding by azusa
|
Emissive and Ambient lighting are pixel perfect. Updated Lugia: |
-credits to azusa once more
Jaklyy
changed the title
still far from correct, but its a start. fixes: melonDS-emu#1545
Jaklyy
force-pushed
the
lighting-test
branch
from
5fda106
to
ef2dade
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: This pr improves the algorithm for diffuse lighting to be (near?) perfect, thanks to discoveries by asuza.
This also changes the way fractional color precision is handled to be maintained until all lights are calculated.
Previous text:
Fixes #1966
Results in lighting being noticeably brighter when multiple lights are enabled.
Colors seem to match hardware better.
Doesn't appear to be perfect, though it's possible those imperfections are due to inaccurate interpolation rather than problems with the lighting calc itself.
Definitely needs some test rom verification, though.
Before:
After:
HW Capture (frame dump "reconstructed full color" screenshot):