Feat: Extend Lock #215
Merged
Feat: Extend Lock #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…ing for locking errors
…disable relocking for accounts w/ multiple locks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds functionality to allow users to extend their mentor lock. It also changes how locks are thought of and displayed in the UI. We no longer display a list of all the lock actions taken by the user; we now only have three things, along with buttons to either withdraw unlocked mentors or extend their current lock expiration date. One thing to note is this function can also add amounts to a lock; we don't support that with this implementation; this is strictly extending an existing lock with/ the same locked amount.
Multiple Locks
Our plan for the UI is not to support creating multiple locks. However, a user can technically create multiple locks by calling the contract directly. We need to decide how we handle users who have them because the current implementation of relocking cannot support them. This implementation disables relocking for such users.
For reviewers -
There are serval accounts in the testathon deployment doc which have extendable locks. One of them to go through the extend flow.
Other changes
Changed all 'my voting power' references to just 'voting power'.
Disable the locking component for users who already have locks. In it's previous state this component allows users to create multiple locks, which we don't want.
Adding
Tested
Used the UI on both mobile & extended locks.
Related issues