Prepare for fastify v5 #129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
mcollina
reviewed
Sep 16, 2024
| app.graphql.addHook('preExecution', filterGraphQLSchemaHook.bind(app)) | ||
| if (!err) { | ||
| app.graphql.addHook('preExecution', filterGraphQLSchemaHook.bind(app)) | ||
| } |
There was a problem hiding this comment.
Are you sure about this? Isn't it swallowing the error?
There was a problem hiding this comment.
Yeah I thought the same and it's related to the issue I was coming up against! If I leave as it, app.ready() rejects with the expected error but then the error is thrown again within this callback and causes unhandled rejection issues.
Even though we're swallowing the error here, it's still being thrown, as shown and caught in this test here: https://github.com/mercurius-js/auth/blob/main/test/introspection-filter.js#L359
wdyt? Reckon it's worth looking for a better solution?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the following changes