Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edited n00b-GettingStarted.md and smaller edits to README.md and n00b-overview.md #1270

Merged
merged 28 commits into from
Feb 27, 2020
Merged

Conversation

NeilCuzon
Copy link
Member

@NeilCuzon NeilCuzon commented Feb 22, 2020

Hi, I love your program and how it creates diagrams and graphs using text. but I had some small trouble in initially understanding the product's use..

I updated and expanded documentation for noob-gettingStarted.md.
-made some alterations with the instructions in effort to make it more n00b friendly.
-added a new screenshot and edited directions for copying markdown code from live editor
-edited instructions for deploying mermaid with html.
-added link to Atom-mermaid plugin

I also made a few changes in README.md, for the same objective of making it more noob-friendly.

More Power.
-Neil

Hi, I love your program and how it reimagines the whole dynamic of creating diagrams and graphs, I also like the wit of the documentation, but I had some small trouble in initially figuring out what the application was about. 

I propose a few line changes to clarify the purpose of the application and an additional a link to the syntax section of docs to  hopefully decrease the friction and increase the interest in using the product.  
I changed:
-"__mermaid is a Javascript based diagramming and charting tool. It generates diagrams flowcharts and more, using markdown-inspired text for ease and speed.__"
and I added:
-"__The following are some examples of the diagrams, charts and graphs that can be made using mermaid and the Markdown-inspired text specific to it. Click here jump into the [text syntax](https://mermaid-js.github.io/mermaid/#/n00b-syntaxReference).__"


More power to you and your team.
-Neil
this section had some outdated info regarding the live editor and its capabilities. 
-replaced and outdated screenshot
-edited the documentation to make it a little more n00b friendly. 
-added a link to the Atom mermaid plugin

-Neil
updated documentation for noob-gettingStarted.md. 
-added a new screenshot and edited directions for copying markdown code from live editor
-made some alterations with the instructions in effort to make it more n00b friendly.
-added link to Atom-mermaid plugin
@NeilCuzon NeilCuzon closed this Feb 23, 2020
@NeilCuzon NeilCuzon reopened this Feb 23, 2020
@NeilCuzon NeilCuzon changed the title Small edits to README.md and description Edited n00b-GettingStarted.md and smaller edits to README.md Feb 24, 2020
README.md Outdated
See our [documentation](http://mermaid-js.github.io/mermaid/) and start simplifying yours. Play in our [live editor](https://mermaidjs.github.io/mermaid-live-editor/) or jump straight to the [installation and usage](http://mermaid-js.github.io/mermaid/#/usage).
__mermaid is a Javascript based diagramming and charting tool. It generates diagrams flowcharts and more, using markdown-inspired text for ease and speed.__

For more information and help in gettin started, please view our [documentation](http://mermaid-js.github.io/mermaid/) and start simplifying yours. Play with our [live editor](https://mermaidjs.github.io/mermaid-live-editor/) or jump straight to the [installation and usage](http://mermaid-js.github.io/mermaid/#/usage).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in gettin started

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noted, will correct it immediately.

@NeilCuzon NeilCuzon changed the title Edited n00b-GettingStarted.md and smaller edits to README.md Edited n00b-GettingStarted.md and smaller edits to README.md and n00b-overview.md Feb 24, 2020
@knsv knsv requested a review from erelling February 25, 2020 18:15
docs/n00b-overview.md Outdated Show resolved Hide resolved
docs/n00b-overview.md Outdated Show resolved Hide resolved
docs/n00b-overview.md Outdated Show resolved Hide resolved
Copy link
Contributor

@mvandermade mvandermade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo's

Copy link
Collaborator

@erelling erelling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and well done!

docs/n00b-overview.md Outdated Show resolved Hide resolved
@NeilCuzon
Copy link
Member Author

thank you for the reviews, I'll correct them immediately.

@NeilCuzon
Copy link
Member Author

thanks for the reviews and the edits! this is my first time contributing to Github and I'm thankful for the guidance.

@knsv knsv merged commit dcd807c into mermaid-js:develop Feb 27, 2020
@erelling
Copy link
Collaborator

😃First timers you and me both!

@mvandermade
Copy link
Contributor

Good to hear! Have fun :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants