Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localVolumes Instance property is lost with Marathon restart #5165

Closed
timcharper opened this issue Feb 10, 2017 · 1 comment
Closed

localVolumes Instance property is lost with Marathon restart #5165

timcharper opened this issue Feb 10, 2017 · 1 comment
Assignees

Comments

@timcharper
Copy link
Contributor

timcharper commented Feb 10, 2017

It appears that localVolumes is not persisted properly.

  1. Launch the following app def:
{
  "id": "/le-sleep",
  "cmd": "sleep 3600",
  "cpus": 1,
  "mem": 128,
  "disk": 0,
  "instances": 3,
  "constraints": [
    [
      "hostname",
      "UNIQUE"
    ]
  ],
  "container": {
    "type": "MESOS",
    "volumes": [
      {
        "containerPath": "hi",
        "mode": "RW",
        "persistent": {
          "size": 16,
          "type": "root",
          "constraints": []
        }
      }
    ]
  }
}
  1. Curl the API and get the tasks:

You'll see once that looks like this:

{
  "localVolumes": [
    {
      "runSpecId": "/le-sleep",
      "containerPath": "hi",
      "uuid": "79bb63c7-efe2-11e6-bcfd-469762eea0d6",
      "persistenceId": "le-sleep#hi#79bb63c7-efe2-11e6-bcfd-469762eea0d6"
    }
  ],
  "stagedAt": "2017-02-10T22:44:26.814Z",
  "state": "TASK_RUNNING",
  "ports": [
    31589
  ],
  "startedAt": "2017-02-10T22:44:26.988Z",
  "version": "2017-02-10T22:44:26.429Z",
  "id": "le-sleep.79bb63c8-efe2-11e6-bcfd-469762eea0d6",
  "appId": "/le-sleep",
  "slaveId": "caf86dd5-62cc-47bd-82e8-1f4fef7002ea-S2",
  "host": "mesos-3.dev.vagrant"
}
  1. Restart Marathon.

  2. Curl the tasks endpoint again and the localVolumes property will be missing.

{
  "stagedAt": "2017-02-10T22:44:26.814Z",
  "state": "TASK_RUNNING",
  "ports": [
    31589
  ],
  "startedAt": "2017-02-10T22:44:26.988Z",
  "version": "2017-02-10T22:44:26.429Z",
  "id": "le-sleep.79bb63c8-efe2-11e6-bcfd-469762eea0d6",
  "appId": "/le-sleep",
  "slaveId": "caf86dd5-62cc-47bd-82e8-1f4fef7002ea-S2",
  "host": "mesos-3.dev.vagrant"
}
@timcharper timcharper self-assigned this Feb 10, 2017
@timcharper timcharper added this to the Marathon 1.4 milestone Feb 10, 2017
@timcharper timcharper added ready and removed next labels Feb 13, 2017
@marcomonaco marcomonaco added next and removed ready labels Feb 14, 2017
timcharper pushed a commit that referenced this issue Feb 16, 2017
Previously, all tasks were being read as LaunchedEphemeral task
subtypes, and this was leading to any resident information about the
task to be lost.

This change fixes the issue, and adds round-trip serialization tests.

Fixed #5165
@timcharper
Copy link
Contributor Author

@timcharper timcharper mentioned this issue Feb 22, 2017
2 tasks
timcharper pushed a commit that referenced this issue Feb 23, 2017
Summary:
Previously, all tasks were being read as LaunchedEphemeral task
subtypes, and this was leading to any resident information about the
task to be lost.

This change fixes the issue, and adds round-trip serialization tests.

Fixed #5165

Backport of dad4e1f

Test Plan: unit

Reviewers: aquamatthias, meichstedt

Subscribers: marathon-team

Differential Revision: https://phabricator.mesosphere.com/D546
timcharper pushed a commit that referenced this issue Feb 23, 2017
Summary:
Previously, all tasks were being read as LaunchedEphemeral task
subtypes, and this was leading to any resident information about the
task to be lost.

This change fixes the issue, and adds round-trip serialization tests.

Fixed #5165

Backport of dad4e1f

Test Plan: unit

Reviewers: aquamatthias, meichstedt

Subscribers: marathon-team

Differential Revision: https://phabricator.mesosphere.com/D546
@mesosphere mesosphere locked and limited conversation to collaborators Mar 27, 2017
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants