-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add a list of alternate disk names to HardwareDetails #1269
Conversation
Skipping CI for Draft Pull Request. |
// A list of alternate Linux device names of the disk, e.g. "/dev/sda". | ||
// Note that this list is not exhaustive, and names may not be stable | ||
// across reboots. | ||
AlternateNames []string `json:"alternateNames,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To clarify this will be a list of known device names from Inspection excluding the one in Name
field?
Also maybe we should sort | uniq
this list somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the proposed implementation it includes the name in the name
field, and entries are unique. Also, the true kernel device (e.g. /dev/sda
) always appears first.
Give users a way of seeing all of the alternate names for the disk that we have discovered, even if they are not stable across reboots.
91f868a
to
505781a
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: honza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test-ubuntu-integration-main |
/lgtm |
@hardys: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Please add PR type (:seedling: etc) to the PR title. |
/retitle ✨ Add a list of alternate disk names to HardwareDetails |
/lgtm |
@hardys looks like you need to submit a review to move yourself out of OWNERS purgatory 😄 (welcome back!) |
This is a follow up (and depends on) #1264.
Give users a way of seeing all of the alternate names for the disk that
we have discovered, even if they are not stable across reboots.