-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Log node updates with a normal logger #1420
Conversation
These updates are pretty critical and very hard to track otherwise.
/test-centos-e2e-integration-main |
This is going to get pretty chatty. Every single bit of data we write to ironic will get logged. I'm not sure we want that. |
Yes, we absolutely do want that. This is much less chatty that the stuff we already log. If you take a look at what we log, you'll see what I mean. The reason for proposing this patch is a bug where BMO gets stuck trying to update deploy_interface on an externally provisioned node - an operation that just should not happen, but it does, and I don't even know what the values are. So, while I support the idea of having the debug flag, this is one of the first things that must never be covered by it. |
Here are some numbers from the recent run:
which may seem a lot, but it's less than 4% of all messages. For contrast:
... and the CI does not even use BMC subscriptions! |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.