🌱 Fix ensure-minikube script to allow minikube versions greater than MINIMUM_MINIKUBE_VERSION #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metal3-io-bot
added
the
size/XS
maxrantil
force-pushed
the
fix-ensure-minikube-v/max
branch
from
e33ff69
to
8cd639b
Compare
…NIMUM_MINIKUBE_VERSION Signed-off-by: Max Rantil <max.rantil@est.tech>
maxrantil
force-pushed
the
fix-ensure-minikube-v/max
branch
from
8cd639b
to
4d1f389
Compare
|
/metal3-bmo-e2e-test |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
/test-centos-e2e-integration-main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The existing state of
ensure_minikube.shtriggers a misleading error during local e2e tests, even when the Minikube version surpasses the definedMINIMUM_MINIKUBE_VERSION. This pull request addresses this issue by enhancing theensure-minikubescript to gracefully handle Minikube versions that exceed the specifiedMINIMUM_MINIKUBE_VERSION.