-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Install golangci-lint directly instead of building it using go-modules #1522
🌱 Install golangci-lint directly instead of building it using go-modules #1522
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny nit.
8764595
to
4936275
Compare
/test-centos-e2e-integration-main |
/metal3-bmo-e2e-test |
Whaow! That's a lot of cleaning up lines :) LGTM |
Signed-off-by: Kashif Khan <kashif.khan@est.tech>
4936275
to
d4f8c1d
Compare
/test-centos-e2e-integration-main |
/metal3-bmo-e2e-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test-centos-e2e-integration-main |
/metal3-bmo-e2e-test |
This is great. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: honza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/metal3-bmo-e2e-test |
/cherry-pick release-0.5 |
@kashifest: new pull request created: #1601 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
as a benefit we get rid of the hashicorp dependencies from
hack/tools/go.mod
.