Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Add trigger phrases and status badge for e2e tests #1525

Merged
merged 1 commit into from
Jan 26, 2024
Merged

📖 Add trigger phrases and status badge for e2e tests #1525

merged 1 commit into from
Jan 26, 2024

Conversation

lentzi90
Copy link
Member

What this PR does / why we need it:

This adds the trigger phrases for the e2e tests to the README.md and also the build badge for the periodic job.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 19, 2024
@lentzi90
Copy link
Member Author

/test metal3-bmo-e2e-test-pull
/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@maxrantil
Copy link
Member

nice, LGTM

@lentzi90
Copy link
Member Author

Wait there is something wrong with the build badge. It doesn't show the correct text
/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2024
@lentzi90
Copy link
Member Author

Ok now it looks better
/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2024
kashifest
kashifest reviewed Jan 19, 2024
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2024
@lentzi90
Copy link
Member Author

/test metal3-bmo-e2e-test-pull
/test-centos-e2e-integration-main
/test-ubuntu-integration-main

smoshiur1237
smoshiur1237 reviewed Jan 19, 2024
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

elfosardo
elfosardo reviewed Jan 19, 2024
View reviewed changes
README.md Outdated
@@ -39,6 +40,11 @@ Eventually these tests will be replaced with BMO's own
[e2e tests](test/e2e/README.md). BMO e2e tests are currently under active
development. Here are the tests which run on different branches in BMO:

**E2e tests:**

* **/test metal3-bmo-e2e-test-pull** runs required BMO e2e tests on your PR. Works for main and release-0.5 branches.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be interesting to have a description of the tests included here and the optional ones too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! I wonder if it perhaps is a bit premature, at least for the optional tests? I'm afraid the list would be constantly changing (or worse, outdated).
Another question is if it should be here or in the test/e2e/README.md?
What do you think?

Copy link
Member

@elfosardo elfosardo Jan 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point for the optional tests, let's wait a bit for when they're more "stable"
I guess adding the description for the required ones to test/e2e/README.md and add a link here would work

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, please take a look 🙂

@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 22, 2024
tuminoid
tuminoid reviewed Jan 22, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit.

README.md Outdated Show resolved Hide resolved
@tuminoid
Copy link
Member

LGTM, I'll leave it to @elfosardo to flag it if he's also happy.

@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Jan 24, 2024
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Jan 25, 2024
elfosardo
elfosardo reviewed Jan 25, 2024
View reviewed changes
Copy link
Member

@elfosardo elfosardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

test/e2e/README.md Outdated Show resolved Hide resolved
@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2024
@lentzi90
Add trigger phrases and status badge for e2e tests
3bbfb67 
This adds the trigger phrases for the e2e tests to the README.md and
also the build badge for the periodic job.
The two e2e test sets are described a bit more in the e2e README.md.

Signed-off-by: Lennart Jern <lennart.jern@est.tech>
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2024
@lentzi90
Copy link
Member Author

/test metal3-bmo-e2e-test-pull
/test-centos-e2e-integration-main
/test-ubuntu-integration-main

@elfosardo
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2024
@lentzi90
Copy link
Member Author

/test-centos-e2e-integration-main

@metal3-io-bot metal3-io-bot merged commit 8bab491 into metal3-io:main Jan 26, 2024
14 checks passed
@metal3-io-bot metal3-io-bot deleted the lentzi90/e2e-trigger-docs branch January 26, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@elfosardo elfosardo elfosardo left review comments

@kashifest kashifest kashifest left review comments

@smoshiur1237 smoshiur1237 smoshiur1237 left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lentzi90 @maxrantil @metal3-io-bot @tuminoid @elfosardo @kashifest @smoshiur1237