🌱 add workflow to approve actions on PR change #1654
Conversation
If external contributor adds a PR, and a member /ok-to-test it, GH actions do not run until approved by an approver. This approval needs to be given if the PR content changes, so it inconveniences the contributor but also the approver. This PR approves workflows, if ok-to-test label is present. Adapted from CAPI workflow: https://github.com/kubernetes-sigs/cluster-api/blob/main/.github/workflows/pr-gh-workflow-approve.yaml Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
metal3-io-bot
added
do-not-merge/hold
|
IPAM tested: metal3-io/ip-address-manager#485 (comment) /unhold |
metal3-io-bot
removed
the
do-not-merge/hold
|
IPAM test already shows this works. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
|
/override test-centos-e2e-integration-main metal3-bmo-e2e-test-pull |
|
@kashifest: Overrode contexts on behalf of kashifest: metal3-bmo-e2e-test-pull, test-centos-e2e-integration-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
If external contributor adds a PR, and a member /ok-to-test it, GH actions do not run until approved by an approver. This approval needs to be given if the PR content changes, so it inconveniences the contributor but also the approver.
This PR approves workflows, if ok-to-test label is present.
Adapted from CAPI workflow:
https://github.com/kubernetes-sigs/cluster-api/blob/main/.github/workflows/pr-gh-workflow-approve.yaml
Same as metal3-io/ip-address-manager#485
/hold
until IPAM workflow gets tested.