🌱 Refactoring: split update_opts.go and updateopts_test.go #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok-to-test |
metal3-io-bot
added
ok-to-test
|
/retitle 🌱 Refactoring: split update_opts.go and updateopts_test.go |
metal3-io-bot
changed the title
update_opts.go contains helpers for Ironic PATCH API that are not tied to the provisioner and thus are better haused in the clients module (renamed to match the existing convention). updateopts_test.go is a mix of tests for update_opts.go and a few provision-specific functions. The former are migrated to clients as well, the latter - to the more suitable provision_test.py. Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
dtantsur
force-pushed
the
refactor/updateopts
branch
from
849911e
to
6d8ab3b
Compare
|
/test metal3-bmo-e2e-test-pull |
2 similar comments
|
/test metal3-bmo-e2e-test-pull |
|
/test metal3-bmo-e2e-test-pull |
|
/lgtm |
|
/ok-to-test |
|
/cc @kashifest @honza @zaneb |
|
Seems reasonable to me /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: honza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update_opts.go contains helpers for Ironic PATCH API that are not tied
to the provisioner and thus are better haused in the clients module
(renamed to match the existing convention).
updateopts_test.go is a mix of tests for update_opts.go and a few
provision-specific functions. The former are migrated to clients as
well, the latter - to the more suitable provision_test.py.
Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com